std: use stream_position where applicable
#120900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @joshtriplett. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
marcospb19
commented
Feb 11, 2024
| /// opening, and after every write, the position for reading may be set at the | ||
| /// end of the file. So, before writing, save the current position (using | ||
| /// <code>[seek]\([SeekFrom]::[Current]\(0))</code>), and restore it before the next read. | ||
| /// <code>[Seek]::[stream_position]</code>), and restore it before the next read. |
There was a problem hiding this comment.
This was the motivating piece of documentation, but then I started applying to other places (where it was OK to do so).
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
|
r=me once CI passes. |
|
r? libs |
by replacing `seek(SeekFrom::Current(0))` calls
marcospb19
force-pushed
the
std-use-seek-stream-position
branch
from
7a98498 to
af6840b
Compare
From triage - seems like this hasn't been set to review state |
rustbot
added
S-waiting-on-review
|
@bors r=joshtriplett |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#120900 (std: use `stream_position` where applicable) - rust-lang#123373 (skip Codegen{GCC,Cranelift} when using CI rustc) - rust-lang#123618 (Discard overflow obligations in `impl_may_apply`) - rust-lang#123905 (rustdoc: check redundant explicit links with correct itemid) - rust-lang#123915 (improve documentation slightly regarding some pointer methods) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
Rollup merge of rust-lang#120900 - marcospb19:std-use-seek-stream-position, r=joshtriplett std: use `stream_position` where applicable by replacing `seek(SeekFrom::Current(0))` calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by replacing
seek(SeekFrom::Current(0))calls